Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EFS File Systems configuration in Amazon ECS and AWS Fargate #12741

Closed
marcincuber opened this issue Apr 9, 2020 · 11 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@marcincuber
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add support for new feature EFSVolumeConfiguration which is available for ECS + Fargate running platform version 1.4.

References

@marcincuber marcincuber added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 9, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2020
@DrFaust92
Copy link
Collaborator

EFSVolumeConfiguration support is already present but was not tested with fargate (there is no particular fargate config for this block)

the IAM and Access Point configs needs to be added

@marcincuber
Copy link
Author

@DrFaust92 I tried upgrading my ECS Fargate services using latest terraform provider and it didn't upgrade it to platform version 1.4. Could it be that it requires SDK upgrade as well?

@DrFaust92
Copy link
Collaborator

Can you share your config?

The changes are for ecs task definition and the platform version is part of ecs service (may be needed to specify explicitly 1.4 and not the default)

I'll try to test it but I don't see anything in the new sdk version that's related

@marcincuber
Copy link
Author

marcincuber commented Apr 9, 2020

Hi I am using my module which you can find here together with the ecs_service resources. https://github.com/umotif-public/terraform-aws-ecs-fargate/blob/master/main.tf#L220

I am not specifying platform_version which means that for FARGATE it should default to LATEST which is 1.4. You could be right that explicitly specifying version would work but then that means LATEST option doesn't work.

@DrFaust92
Copy link
Collaborator

tested it, does not work in either config. well have to wait for the new sdk version merge and try again then.

@bflad
Copy link
Contributor

bflad commented Apr 9, 2020

LATEST not being "latest" may be confirmed here: aws/containers-roadmap#53 (comment) (e.g. an API issue)

@tabletcorry
Copy link

LATEST still points to 1.3.0 per the docs: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/platform_versions.html

To use a specific platform version, specify the version number when creating or updating your service. If you specify LATEST, your tasks use platform version 1.3.0.

So to test this, you must specify 1.4.0 at the moment.

@DrFaust92
Copy link
Collaborator

DrFaust92 commented Apr 9, 2020 via email

@travisz
Copy link

travisz commented Apr 9, 2020

Thanks @tabletcorry! Just tested with 1.4.0 and confirmed it worked :)

@marcincuber
Copy link
Author

marcincuber commented Apr 10, 2020

So to wrap up this issue. This feature is already supported and to use the latest version of fargate we need to specify the following:

resource "aws_ecs_service" "service" {
  ...
  platform_version = "1.4.0"
}

and for some random reason LATEST version still points at 1.3.0 version.

@ghost
Copy link

ghost commented May 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 10, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

No branches or pull requests

6 participants