Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ClientVpcIpAddress for built Kafka clusters #11085

Closed
KushalP opened this issue Dec 2, 2019 · 6 comments · Fixed by #20615
Closed

Expose ClientVpcIpAddress for built Kafka clusters #11085

KushalP opened this issue Dec 2, 2019 · 6 comments · Fixed by #20615
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service.
Milestone

Comments

@KushalP
Copy link

KushalP commented Dec 2, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When we've created a Kafka cluster, expose the IPs of the individual brokers as an attribute so that they can be used for other configuration. This is already being exposed by the AWS Go SDK: https://github.com/aws/aws-sdk-go/blob/363ee75f96be07cb7dd905ad9fda37d0eeafeb68/service/kafka/api.go#L2204

New or Affected Resource(s)

@KushalP KushalP added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 2, 2019
@ghost ghost added the service/kafka Issues and PRs that pertain to the kafka service. label Dec 2, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 2, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 8, 2020
@carl34
Copy link

carl34 commented Apr 14, 2020

Hi, here's some candidate code to use list_nodes to add a new output containing a comma separated list of all ClientVpcIpAddress values for a cluster.

https://github.com/carl34/terraform-provider-aws/blob/msk_list_nodes/website/docs/r/msk_cluster.html.markdown

Example:

output "broker_client_vpc_ip_address" {
  description = "Broker IP Addresses"
  value       " "${aws_msk_cluster.example.broker_client_vpc_ip_addresses}"
}

broker_client_vpc_ip_addresses = 10.0.0.1,10.0.0.2,10.0.0.3

I've run the code successfully, but am still working on unit testing. Please let me know if someone who is familiar with the MSK unit tests can assist.

@carl34
Copy link

carl34 commented Apr 14, 2020

[WIP] PR created, #12821

@carl34
Copy link

carl34 commented Jul 15, 2020

Unit test output added to #12821, removed [WIP] from the PR

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 17, 2021

I think the best solution for this will be a new aws_msk_nodes data source as implemented in #20615.

@github-actions github-actions bot added this to the v3.60.0 milestone Sep 17, 2021
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service.
Projects
None yet
4 participants