Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_db_instance should support ca_cert_identifier #10489

Closed
sunilkumarmohanty opened this issue Oct 13, 2019 · 4 comments · Fixed by #10490
Closed

aws_db_instance should support ca_cert_identifier #10489

sunilkumarmohanty opened this issue Oct 13, 2019 · 4 comments · Fixed by #10490
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone
v2.37.0

Comments

@sunilkumarmohanty
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

  • aws_db_instance

Potential Terraform Configuration

resource "aws_db_instance" "test" {

	ca_cert_identifier = "rds-ca-2019"
        ...
}

References
@sunilkumarmohanty sunilkumarmohanty added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 13, 2019
@ghost ghost added the service/rds Issues and PRs that pertain to the rds service. label Oct 13, 2019
@sunilkumarmohanty sunilkumarmohanty mentioned this issue Oct 13, 2019
Merged
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 13, 2019
@tomelliff
Copy link
Contributor

This looks like a duplicate of #10417

@bflad bflad added this to the v2.37.0 milestone Nov 15, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2019
@bflad
Copy link
Contributor

bflad commented Nov 15, 2019

Support for the new ca_cert_identifier argument in the aws_db_instance resource has been merged and will release in version 2.37.0 of the Terraform AWS Provider by Thursday next week. Thanks to @sunilkumarmohanty for the implementation. 👍

@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

philandstuff added a commit to alphagov/gsp that referenced this issue Jan 20, 2020
@philandstuff
specify a minimum aws provider version
5b3235d 
We need minimum 2.37 so we can have ca_cert_identifier in
aws_db_instance [1].  Specifying the minimum version here will force
an upgrade if anyone (say, me) has a cached aws provider of an earlier
version.

[1]: hashicorp/terraform-provider-aws#10489
@philandstuff philandstuff mentioned this issue Jan 20, 2020
Merged
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Milestone
v2.37.0
Development

Successfully merging a pull request may close this issue.

add ca_cert_identifier to rds instance sunilkumarmohanty/terraform-provider-aws
3 participants
@bflad @tomelliff @sunilkumarmohanty