-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
service/appmesh: Handle read-after-create eventual consistency in res…
…ources (#18529) * service/appmesh: Handle read-after-create eventual consistency in resources Reference: #15084 Reference: #16796 Reference: https://blog.envoyproxy.io/embracing-eventual-consistency-in-soa-networking-32a5ee5d443d Output from acceptance testing in AWS Commercial: ``` --- FAIL: TestAccAWSAppmesh_serial (1654.08s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (64.89s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (27.55s) --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (37.34s) --- PASS: TestAccAWSAppmesh_serial/VirtualService (102.18s) --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (30.51s) --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (27.91s) --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (43.76s) --- PASS: TestAccAWSAppmesh_serial/GatewayRoute (180.76s) --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/httpRoute (31.38s) --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/http2Route (30.54s) --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/tags (45.18s) --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/basic (18.19s) --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/disappears (14.95s) --- PASS: TestAccAWSAppmesh_serial/GatewayRoute/grpcRoute (40.53s) --- PASS: TestAccAWSAppmesh_serial/Mesh (73.44s) --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (12.91s) --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (29.35s) --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (31.18s) --- FAIL: TestAccAWSAppmesh_serial/Route (429.26s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (43.23s) --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (42.71s) --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (30.21s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteEmptyMatch (17.81s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (31.13s) --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (31.08s) --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (32.21s) --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (31.77s) --- PASS: TestAccAWSAppmesh_serial/Route/tags (44.91s) --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (54.42s) --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (30.70s) --- FAIL: TestAccAWSAppmesh_serial/Route/httpHeader (8.24s) # #18528 --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (30.84s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway (285.66s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerConnectionPool (26.22s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerHealthChecks (26.25s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerTls (70.19s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/basic (17.09s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/disappears (12.66s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaultsCertificate (15.85s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/tags (38.11s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/backendDefaults (26.15s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/listenerValidation (26.61s) --- PASS: TestAccAWSAppmesh_serial/VirtualGateway/logging (26.53s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode (517.90s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (26.74s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (26.37s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (38.61s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (12.41s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (26.83s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (99.43s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (15.51s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (50.89s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (69.86s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (27.28s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate (15.92s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerValidation (26.70s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (28.32s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (26.63s) --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (26.40s) ``` * Update CHANGELOG for #18529 * tests/resource/aws_appmesh_route: Fix httpHeader test configuration Reference: #18528 Reference: https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_HttpRouteMatch.html#appmesh-Type-HttpRouteMatch-scheme Previously: ``` === RUN TestAccAWSAppmesh_serial/Route/httpHeader resource_aws_appmesh_route_test.go:1084: Step 1/3 error: Error running apply: exit status 1 Error: error creating App Mesh route: ForbiddenException: Scheme matching in HTTP routes is not supported. on terraform_plugin_test.tf line 34, in resource "aws_appmesh_route" "test": 34: resource "aws_appmesh_route" "test" { ``` Output from acceptance test: ``` --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (31.41s) ```
- Loading branch information
Showing
11 changed files
with
322 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
```release-note:bug | ||
resource/aws_appmesh_gateway_route: Handle read-after-create eventual consistency | ||
``` | ||
|
||
```release-note:bug | ||
resource/aws_appmesh_mesh: Handle read-after-create eventual consistency | ||
``` | ||
|
||
```release-note:bug | ||
resource/aws_appmesh_route: Handle read-after-create eventual consistency | ||
``` | ||
|
||
```release-note:bug | ||
resource/aws_appmesh_virtual_gateway: Handle read-after-create eventual consistency | ||
``` | ||
|
||
```release-note:bug | ||
resource/aws_appmesh_virtual_router: Handle read-after-create eventual consistency | ||
``` | ||
|
||
```release-note:bug | ||
resource/aws_appmesh_virtual_service: Handle read-after-create eventual consistency | ||
``` | ||
|
||
```release-note:bug | ||
resource/aws_appmesh_virtual_node: Handle read-after-create eventual consistency | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package waiter | ||
|
||
import ( | ||
"time" | ||
) | ||
|
||
const ( | ||
// Maximum amount of time to wait for Appmesh changes to propagate | ||
PropagationTimeout = 2 * time.Minute | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.