Skip to content

Commit

Permalink
tests/service: Fix linting
Browse files Browse the repository at this point in the history
  • Loading branch information
YakDriver committed Jan 11, 2021
1 parent c9c344b commit 93e5fe9
Showing 1 changed file with 29 additions and 10 deletions.
39 changes: 29 additions & 10 deletions aws/data_source_aws_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,25 @@ func TestAccAWSService_byDNSName(t *testing.T) {
})
}

func TestAccAWSService_byParts(t *testing.T) {
dataSourceName := "data.aws_service.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
Steps: []resource.TestStep{
{
Config: testAccCheckAwsServiceConfig_byPart(),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(dataSourceName, "dns_name", fmt.Sprintf("%s.%s.%s", s3.EndpointsID, testAccGetRegion(), "amazonaws.com")),
resource.TestCheckResourceAttr(dataSourceName, "reverse_dns_name", fmt.Sprintf("%s.%s.%s", "com.amazonaws", testAccGetRegion(), s3.EndpointsID)),
resource.TestCheckResourceAttr(dataSourceName, "supported", "true"),
),
},
},
})
}

func TestAccAWSService_unsupported(t *testing.T) {
dataSourceName := "data.aws_service.test"

Expand All @@ -101,46 +120,46 @@ func TestAccAWSService_unsupported(t *testing.T) {
}

func testAccCheckAwsServiceConfig_basic() string {
return fmt.Sprintf(`
return `
data "aws_service" "default" {}
`)
`
}

func testAccCheckAwsServiceConfig_byReverseDNSName() string {
// lintignore:AWSAT003
return fmt.Sprintf(`
return `
data "aws_service" "test" {
reverse_dns_name = "cn.com.amazonaws.cn-north-1.s3"
}
`)
`
}

func testAccCheckAwsServiceConfig_byDNSName() string {
// lintignore:AWSAT003
return fmt.Sprintf(`
return `
data "aws_service" "test" {
dns_name = "rds.us-east-1.amazonaws.com"
}
`)
`
}

func testAccCheckAwsServiceConfig_byPart() string {
return fmt.Sprintf(`
return `
data "aws_region" "current" {}
data "aws_service" "test" {
reverse_dns_prefix = "com.amazonaws"
region = data.aws_region.current.name
service_id = "s3"
}
`)
`
}

func testAccCheckAwsServiceConfig_unsupported() string {
// lintignore:AWSAT003
return fmt.Sprintf(`
return `
data "aws_service" "test" {
reverse_dns_name = "com.amazonaws.us-gov-west-1.waf"
}
`)
`
}

0 comments on commit 93e5fe9

Please sign in to comment.