Merge pull request #37627 from professional-ian/appfabric-ingestion-d…

…estination

add aws_appfabric_ingestion_destination resource

.changelog/37627.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_appfabric_ingestion_destination
+```

internal/service/appfabric/app_authorization.go

@@ -18,6 +18,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
 	"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
+	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
@@ -235,6 +236,7 @@ func (r *appAuthorizationResource) Create(ctx context.Context, request resource.
 	appAuthorization, err := waitAppAuthorizationCreated(ctx, conn, data.AppAuthorizationARN.ValueString(), data.AppBundleARN.ValueString(), r.CreateTimeout(ctx, data.Timeouts))
 
 	if err != nil {
+		response.State.SetAttribute(ctx, path.Root(names.AttrID), data.ID) // Set 'id' so as to taint the resource.
 		response.Diagnostics.AddError(fmt.Sprintf("waiting for AppFabric App Authorization (%s) create", data.ID.ValueString()), err.Error())
 
 		return

internal/service/appfabric/app_authorization_connection.go

@@ -13,6 +13,7 @@ import (
 	awstypes "github.com/aws/aws-sdk-go-v2/service/appfabric/types"
 	"github.com/hashicorp/terraform-plugin-framework-timeouts/resource/timeouts"
 	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
+	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
@@ -139,6 +140,7 @@ func (r *appAuthorizationConnectionResource) Create(ctx context.Context, request
 	appAuthorization, err := waitConnectAppAuthorizationCreated(ctx, conn, data.AppAuthorizationARN.ValueString(), data.AppBundleARN.ValueString(), r.CreateTimeout(ctx, data.Timeouts))
 
 	if err != nil {
+		response.State.SetAttribute(ctx, path.Root(names.AttrID), data.ID) // Set 'id' so as to taint the resource.
 		response.Diagnostics.AddError(fmt.Sprintf("waiting for AppFabric App Authorization Connection (%s) create", data.ID.ValueString()), err.Error())
 
 		return

internal/service/appfabric/appfabric_test.go

@@ -42,6 +42,13 @@ func TestAccAppFabric_serial(t *testing.T) {
 			acctest.CtDisappears: testAccIngestion_disappears,
 			"tags":               testAccIngestion_tags,
 		},
+		"IngestionDestination": {
+			acctest.CtBasic:      testAccIngestionDestination_basic,
+			acctest.CtDisappears: testAccIngestionDestination_disappears,
+			"tags":               testAccIngestionDestination_tags,
+			"update":             testAccIngestionDestination_update,
+			"firehose":           testAccIngestionDestination_firehose,
+		},
 	}
 
 	acctest.RunSerialTests2Levels(t, testCases, serializeDelay)

internal/service/appfabric/exports_test.go

@@ -9,9 +9,11 @@ var (
 	ResourceAppAuthorizationConnection = newAppAuthorizationConnectionResource
 	ResourceAppBundle                  = newAppBundleResource
 	ResourceIngestion                  = newIngestionResource
+	ResourceIngestionDestination       = newIngestionDestinationResource
 
 	FindAppAuthorizationByTwoPartKey           = findAppAuthorizationByTwoPartKey
 	FindAppAuthorizationConnectionByTwoPartKey = findAppAuthorizationConnectionByTwoPartKey
 	FindAppBundleByID                          = findAppBundleByID
 	FindIngestionByTwoPartKey                  = findIngestionByTwoPartKey
+	FindIngestionDestinationByThreePartKey     = findIngestionDestinationByThreePartKey
 )