-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
internal/naming: Do not discard terraform- prefixed name prefixes (#1…
…7030) Reference: #17017 Changes: ``` * resource/aws_cloudwatch_event_rule: Prevent perpetual differences with `name_prefix` argument values beginning with `terraform-` * resource/aws_security_group: Prevent perpetual differences with `name_prefix` argument values beginning with `terraform-` ``` Output from acceptance testing: ``` --- PASS: TestAccAWSCloudWatchEventRule_basic (70.77s) --- PASS: TestAccAWSCloudWatchEventRule_description (52.06s) --- PASS: TestAccAWSCloudWatchEventRule_EventBusName (75.08s) --- PASS: TestAccAWSCloudWatchEventRule_IsEnabled (68.71s) --- PASS: TestAccAWSCloudWatchEventRule_Name_Generated (33.92s) --- PASS: TestAccAWSCloudWatchEventRule_NamePrefix (33.93s) --- PASS: TestAccAWSCloudWatchEventRule_pattern (50.64s) --- PASS: TestAccAWSCloudWatchEventRule_role (48.35s) --- PASS: TestAccAWSCloudWatchEventRule_ScheduleAndPattern (33.93s) --- PASS: TestAccAWSCloudWatchEventRule_tags (83.41s) --- PASS: TestAccAWSSecurityGroup_allowAll (39.02s) --- PASS: TestAccAWSSecurityGroup_basic (38.37s) --- PASS: TestAccAWSSecurityGroup_change (82.06s) --- PASS: TestAccAWSSecurityGroup_CIDRandGroups (55.51s) --- PASS: TestAccAWSSecurityGroup_defaultEgressClassic (13.81s) --- PASS: TestAccAWSSecurityGroup_defaultEgressVPC (49.44s) --- PASS: TestAccAWSSecurityGroup_drift (19.07s) --- PASS: TestAccAWSSecurityGroup_driftComplex (49.44s) --- PASS: TestAccAWSSecurityGroup_egressConfigMode (74.91s) --- PASS: TestAccAWSSecurityGroup_egressWithPrefixList (53.22s) --- PASS: TestAccAWSSecurityGroup_failWithDiffMismatch (39.04s) --- PASS: TestAccAWSSecurityGroup_forceRevokeRulesFalse (682.76s) --- PASS: TestAccAWSSecurityGroup_forceRevokeRulesTrue (737.58s) --- PASS: TestAccAWSSecurityGroup_ingressConfigMode (73.28s) --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (14.36s) --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsVPC (39.61s) --- PASS: TestAccAWSSecurityGroup_ingressWithPrefixList (56.36s) --- PASS: TestAccAWSSecurityGroup_invalidCIDRBlock (6.52s) --- PASS: TestAccAWSSecurityGroup_IPRangeAndSecurityGroupWithSameRules (48.10s) --- PASS: TestAccAWSSecurityGroup_IPRangesWithSameRules (35.83s) --- PASS: TestAccAWSSecurityGroup_ipv4andipv6Egress (35.09s) --- PASS: TestAccAWSSecurityGroup_ipv6 (46.26s) --- PASS: TestAccAWSSecurityGroup_multiIngress (45.44s) --- PASS: TestAccAWSSecurityGroup_Name_Generated (32.72s) --- PASS: TestAccAWSSecurityGroup_Name_TerraformPrefix (32.03s) --- PASS: TestAccAWSSecurityGroup_NamePrefix (34.45s) --- PASS: TestAccAWSSecurityGroup_NamePrefix_TerraformPrefix (32.44s) --- PASS: TestAccAWSSecurityGroup_ruleDescription (112.40s) --- PASS: TestAccAWSSecurityGroup_ruleGathering (57.85s) --- PASS: TestAccAWSSecurityGroup_ruleLimitCidrBlockExceededAppend (71.38s) --- PASS: TestAccAWSSecurityGroup_ruleLimitExceededAllNew (88.92s) --- PASS: TestAccAWSSecurityGroup_ruleLimitExceededAppend (81.66s) --- PASS: TestAccAWSSecurityGroup_ruleLimitExceededPrepend (72.60s) --- PASS: TestAccAWSSecurityGroup_rulesDropOnError (72.96s) --- PASS: TestAccAWSSecurityGroup_self (39.48s) --- PASS: TestAccAWSSecurityGroup_sourceSecurityGroup (31.15s) --- PASS: TestAccAWSSecurityGroup_tags (76.38s) --- PASS: TestAccAWSSecurityGroup_vpc (39.96s) --- PASS: TestAccAWSSecurityGroup_vpcNegOneIngress (45.88s) --- PASS: TestAccAWSSecurityGroup_vpcProtoNumIngress (37.04s) ```
- Loading branch information
Showing
8 changed files
with
134 additions
and
103 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
```release-note:bug | ||
resource/aws_cloudwatch_event_rule: Prevent perpetual differences with `name_prefix` argument values beginning with `terraform-` | ||
``` | ||
|
||
```release-note:bug | ||
resource/aws_security_group: Prevent perpetual differences with `name_prefix` argument values beginning with `terraform-` | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.