Skip to content

Commit

Permalink
resource/aws_network_acl_rule: Immediately return DescribeNetworkAcls…
Browse files Browse the repository at this point in the history
… errors on creation (#14261)

Reference: #13409

Output from acceptance testing:

```
--- PASS: TestAccAWSNetworkAclRule_allProtocol (44.33s)
--- PASS: TestAccAWSNetworkAclRule_basic (32.50s)
--- PASS: TestAccAWSNetworkAclRule_disappears (32.83s)
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (27.16s)
--- PASS: TestAccAWSNetworkAclRule_ingressEgressSameNumberDisappears (30.24s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (29.23s)
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (28.65s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (47.71s)
--- PASS: TestAccAWSNetworkAclRule_missingParam (15.14s)
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (40.32s)
```
  • Loading branch information
bflad authored Jul 22, 2020
1 parent 69040e8 commit 47387a4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion aws/resource_aws_network_acl_rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func resourceAwsNetworkAclRuleCreate(d *schema.ResourceData, meta interface{}) e
err = resource.Retry(3*time.Minute, func() *resource.RetryError {
r, err = findNetworkAclRule(d, meta)
if err != nil {
return resource.RetryableError(err)
return resource.NonRetryableError(err)
}
if r == nil {
return resource.RetryableError(fmt.Errorf("Network ACL rule (%s) not found", d.Id()))
Expand Down

0 comments on commit 47387a4

Please sign in to comment.