Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad_computer: add description #85

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Conversation

emyl
Copy link
Contributor

@emyl emyl commented Feb 28, 2021

Description

I'm proposing this slight change since it can be useful in my use case. I'm adding the ability to include a description in computer objects.

Unfortunately I wasn't able to run extensive testing, but I tried to do my best and everything looks correct to me.

Thanks.

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added size/M labels Feb 28, 2021
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 28, 2021

CLA assistant check
All committers have signed the CLA.

@jpatigny
Copy link
Contributor

Tested and working
There was one scenario with "issues".
If you remove the description once it has already been applied, it keeps the "-descritpion" parameter bu empty and the cmdlet doesn't accept.
It would be great to replace the empty space by $null if description is empty.

Super job

Set a computer object's description to $null when the attribute is
removed from the config.
@koikonom
Copy link
Contributor

koikonom commented Apr 8, 2021

Hi @emyl, thanks for opening this PR! I added a commit to address the issue @jpatigny raised.

I will merge it now and it will be included in the next release.

@koikonom koikonom merged commit 6883f69 into hashicorp:main Apr 8, 2021
@ghost
Copy link

ghost commented May 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants