Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptions for user and group datasources. #69

Merged
merged 3 commits into from
Jan 7, 2021

Conversation

koikonom
Copy link
Contributor

@koikonom koikonom commented Jan 5, 2021

No description provided.

@koikonom koikonom requested review from aareet and redeux January 5, 2021 16:41
@koikonom koikonom marked this pull request as draft January 5, 2021 16:42
@ghost ghost added size/XS labels Jan 5, 2021
@koikonom koikonom marked this pull request as ready for review January 5, 2021 16:50
ad/data_source_ad_group.go Outdated Show resolved Hide resolved
@ghost ghost added size/S and removed size/XS labels Jan 6, 2021
Copy link
Contributor

@redeux redeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@koikonom koikonom merged commit abc7485 into main Jan 7, 2021
@koikonom koikonom deleted the fix_datasource_docs branch January 7, 2021 10:17
@ghost
Copy link

ghost commented Feb 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants