Extra TestCheckFuncs to check attribute's string length
#893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2022 18:55
… to check resource attribute string length
This is based on the official [GitHub templates](https://github.com/github/gitignore), plus something for Jetbrains products
5 tasks
|
I'll suggest moving the .gitignore changes to a separate PR. |
helper/resource/testing.go
Outdated
| @@ -1031,6 +1031,36 @@ func testCheckResourceAttrPair(isFirst *terraform.InstanceState, nameFirst strin | |||
| return nil | |||
| } | |||
|
|
|||
| // TestRangeLengthResourceAttr is a TestCheckFunc which checks that the length of the value | |||
| // in state for the given name/key is within an expected (closed) range | |||
There was a problem hiding this comment.
I'm not sure if it matters in this repo, but the last linter PR I looked at wanted .'s at the end of comments.
Co-authored-by: Dave Parfitt <[email protected]>
detro
commented
Mar 1, 2022
bookshelfdave
approved these changes
Mar 1, 2022
detro
commented
Mar 1, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Sometimes, when writing tests for a provider, one needs to check that a value is a certain length or length range, while cannot rely on expecting a specific value to match. This is for example true for situations when the provider will generate a value entirely randomised, but that "should be at least this long/short".
Solution proposed
2 additional functions in
helper/resource/testing.go:func TestRangeLengthResourceAttr(name, key string, min, max int) TestCheckFuncfunc TestMatchLengthResourceAttr(name, key string, length int) TestCheckFuncThis PR comes with tests to exercise this utility.