Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Add data consistency error docs for "planned value does not match config value" #1232

Merged
merged 7 commits into from
Aug 30, 2023

Conversation

austinvalle
Copy link
Member

Ref: #1229

This PR adds additional documentation about a common data consistency error we see during migration to Plugin Framework:

TIMESTAMP [WARN]  Provider "TYPE" produced an invalid plan for ADDRESS, but we are tolerating it because it is using the legacy plugin SDK.
    The following problems may be the cause of any confusing errors from downstream operations:
      - .ATTRIBUTE: planned value cty.StringVal("VALUE") does not match config value cty.StringVal("value")

I added a simplified example for demonstrating the behavior, but can adjust/add more examples if we think that'd be helpful.

@austinvalle austinvalle added the documentation Improvements or additions to documentation label Aug 24, 2023
@austinvalle austinvalle requested a review from a team as a code owner August 24, 2023 21:58
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to hold this excellent content up from going somewhere, but something to potentially consider here. 👍

@austinvalle
Copy link
Member Author

austinvalle commented Aug 29, 2023

@bflad @bendbennett - I moved the code over to a new PR in plugin-framework. I removed the migration section + plugin framework code from this PR and added an SDKv2 solution.

I'd love a second review on the SDKv2 solution I provided, as I was basing a lot of it off my understanding of the Semantic Equality RFC and some sandbox testing. Want to make sure this example makes sense 😄

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 🚀

@austinvalle austinvalle merged commit 3e10d01 into main Aug 30, 2023
@austinvalle austinvalle deleted the av/data-consistency-additions branch August 30, 2023 16:19
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants