-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website: Add data consistency error docs for "planned value does not match config value" #1232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
website/docs/plugin/sdkv2/resources/data-consistency-errors.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to hold this excellent content up from going somewhere, but something to potentially consider here. 👍
website/docs/plugin/sdkv2/resources/data-consistency-errors.mdx
Outdated
Show resolved
Hide resolved
@bflad @bendbennett - I moved the code over to a new PR in plugin-framework. I removed the migration section + plugin framework code from this PR and added an SDKv2 solution. I'd love a second review on the SDKv2 solution I provided, as I was basing a lot of it off my understanding of the Semantic Equality RFC and some sandbox testing. Want to make sure this example makes sense 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 🚀
website/docs/plugin/sdkv2/resources/data-consistency-errors.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Flad <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Ref: #1229
This PR adds additional documentation about a common data consistency error we see during migration to Plugin Framework:
I added a simplified example for demonstrating the behavior, but can adjust/add more examples if we think that'd be helpful.