Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added forcetypeassert, misspell, and paralleltest lint rules #120

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Jan 24, 2023

contributes to:

Notes

  • deadcode and varcheck linters are deprecated in golangci-lint in favor of unused
 $ golangci-lint run
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 

@austinvalle austinvalle requested a review from a team as a code owner January 24, 2023 14:03
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 (not too concerned with the test lintignore)

@bflad bflad added this to the v0.8.0 milestone Jan 24, 2023
@austinvalle austinvalle changed the title ci: added forcetypeassert and misspell lint rules ci: added forcetypeassert, misspell, and paralleltest lint rules Jan 24, 2023
@austinvalle
Copy link
Member Author

Looks good to me 🚀 (not too concerned with the test lintignore)

I added paralleltest to this PR as well 🚀

@austinvalle austinvalle merged commit d9bd74b into main Jan 24, 2023
@austinvalle austinvalle deleted the av/lint branch January 24, 2023 15:25
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants