Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfprotov5+tfprotov6: Require FunctionServer in ProviderServer #354

Closed
wants to merge 1 commit into from

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 14, 2023

Closes #353

This breaking change aligns the tfprotov5 and tfprotov6 packages with the intended design of this Go module, which is to fully implement the Terraform Plugin Protocol. The FunctionServer interface was temporarily optional in v0.20.0 so downstream SDKs could implement and release support first with a lesser likelihood that developers would run into compilation errors when only upgrading a single downstream Go module.

Provider developers should upgrade this Go module only after ensuring their provider Go module is using at least:

Reference: #353

This breaking change aligns the `tfprotov5` and `tfprotov6` packages with the intended design of this Go module, which is to fully implement the Terraform Plugin Protocol. The `FunctionServer` interface was temporarily optional in v0.20.0 so downstream SDKs could implement and release support first with a lesser likelihood that developers would run into compilation errors when only upgrading a single downstream Go module.

Provider developers should upgrade this Go module only after ensuring their provider Go module is using at least:

- github.com/hashicorp/[email protected]
- github.com/hashicorp/[email protected]
- github.com/hashicorp/terraform-plugin-sdk/[email protected]
@bflad bflad added the breaking-change This will impact or improve our compatibility posture label Dec 14, 2023
@bflad bflad added this to the v0.21.0 milestone Dec 14, 2023
@bflad bflad modified the milestones: v0.21.0, v0.22.0 Jan 12, 2024
@bflad bflad modified the milestones: v0.22.0, v0.23.0 Feb 21, 2024
@bflad
Copy link
Contributor Author

bflad commented Mar 12, 2024

Replaced with #388 👍

@bflad bflad closed this Mar 12, 2024
@bflad bflad deleted the bflad/require-FunctionServer branch March 12, 2024 09:55
@austinvalle austinvalle removed this from the v0.23.0 milestone Apr 18, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change This will impact or improve our compatibility posture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfprotov5+tfprotov6: Add FunctionServer to ProviderServer interface
2 participants