Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -no-color to terraform #208

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

jojo43
Copy link
Contributor

@jojo43 jojo43 commented Jul 4, 2020

This fixes #145 .

I tested in my local environment (macOS) with VSCode and it worked as expected.

@radeksimko radeksimko added this to the v0.5.0 milestone Jul 4, 2020
@radeksimko radeksimko added the enhancement New feature or request label Jul 4, 2020
@paultyng
Copy link
Contributor

paultyng commented Jul 8, 2020

@jojo43 thanks for this PR.

Just as a note, we recently opensourced https://github.com/hashicorp/terraform-exec and will probably be moving all the Terraform execution calls to that package eventually.

I'll defer to @radeksimko if he'd like to merge this prior to that, probably makes sense to solve it until we can complete the integration.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is simple enough I'd just merge it before migrating to terraform-exec. I'm working on some bugfixes now, which I'd like to release first, but this LGTM - we can merge with other 0.5.0 PRs 🔜

@radeksimko radeksimko merged commit 3bcb0bb into hashicorp:master Jul 10, 2020
@jojo43 jojo43 deleted the pass-no-color-to-terraform branch July 10, 2020 22:21
@ghost
Copy link

ghost commented Aug 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request terraform/exec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass -no-color to Terraform
3 participants