Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add mandatory cdktf get step #784

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Conversation

DanielMSchmidt
Copy link
Contributor

Closes #612

@skorfmann
Copy link
Contributor

Looks a bit funny when rendered

Screenshot 2021-06-15 at 21 51 58

Other than that, I think it's good 👍

@DanielMSchmidt
Copy link
Contributor Author

@skorfmann fixed it, TIL there is the jsonc format that includes comments in json

the default way should be using pre-built providers
Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@skorfmann skorfmann merged commit e8f27ce into main Jun 17, 2021
@skorfmann skorfmann deleted the docs-add-cdktf-get-step branch June 17, 2021 12:47
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from imports.aws import Instance, AwsProvider
3 participants