Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename instance variable to a more specific name to avoid name collisions #640

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Apr 15, 2021

Resolves #634 which was caused by a Terraform data source which had an attribute containing a list of items which each have a key index which collided with its base class ComplexComputedList.

…ions

resolves #634 which was caused by a terraform data source which had an attribute containing a list of items which each have a key 'index' which collided with its base class ComplexComputedList
@ansgarm ansgarm requested a review from skorfmann April 15, 2021 15:51
Copy link
Contributor

@skorfmann skorfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ansgarm ansgarm merged commit 342b4cc into main Apr 15, 2021
@ansgarm ansgarm deleted the ansgarm/issue634 branch April 15, 2021 19:32
@ansgarm
Copy link
Member Author

ansgarm commented Apr 15, 2021

🚀

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property name and type conflict between generated code and cdktf.ComplexComputedList
2 participants