fix(lib): correct the concat method in TokenizedStringFragments #3772
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
concat
method was not properly updatingthis.fragments
becauseArray.prototype.concat
returns a new array and does not modify the original array in place. Changed the implementation to usethis.fragments.push(...other.fragments);
to correctly merge the fragments intothis.fragments
.Description
I thought
concat
method inTokenizedStringFragments
was intended to merge fragments from another instance intothis.fragments
. However, it was not functioning correctly becauseArray.prototype.concat
returns a new array and does not modify the original array in place.To fix this issue, I updated the
concat
method to usethis.fragments.push(...other.fragments);
. This modifiesthis.fragments
in place and ensures that all fragments are correctly merged.Checklist