Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version of docs conversion tool #3750

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

DanielMSchmidt
Copy link
Contributor

Related issue

Fixes #

Description

In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner October 21, 2024 14:02
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and ansgarm and removed request for a team October 21, 2024 14:02
@DanielMSchmidt DanielMSchmidt merged commit fe2a712 into main Oct 21, 2024
427 of 429 checks passed
@DanielMSchmidt DanielMSchmidt deleted the update-docs-conversion branch October 21, 2024 14:31
@xiehan
Copy link
Member

xiehan commented Oct 24, 2024

Seeing this late: you missed updating https://github.com/hashicorp/terraform-cdk/blob/main/.github/workflows/cdktf-provider-docs-rollout.yml#L50 so Idk if this will actually work

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants