Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib): Correct types for allowedAccountIds & forbiddenAccountIds in S3Backend #3669

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix(lib): Correct types for allowedAccountIds & forbiddenAccountIds in S3Backend #3669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cdktf/lib/backends/s3-backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export interface S3BackendConfig {
* (Optional) List of allowed AWS account IDs to prevent potential destruction of a live environment.
* Conflicts with forbidden_account_ids.
*/
readonly allowedAccountIds?: string;
readonly allowedAccountIds?: string[];
/**
* (Optional) File containing custom root and intermediate certificates.
* Can also be set using the AWS_CA_BUNDLE environment variable.
Expand All @@ -91,7 +91,7 @@ export interface S3BackendConfig {
* (Optional) List of forbidden AWS account IDs to prevent potential destruction of a live environment.
* Conflicts with allowed_account_ids.
*/
readonly forbiddenAccountIds?: string;
readonly forbiddenAccountIds?: string[];
/**
* (Optional) URL of a proxy to use for HTTP requests when accessing the AWS API.
* Can also be set using the HTTP_PROXY or http_proxy environment variables.
Expand Down
Loading