fix: Make CDKTF_LOG_FILE_DIRECTORY a common flag available on all commands
#3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
requested review from
ansgarm and
DanielMSchmidt
and removed request for
a team
DanielMSchmidt
approved these changes
Feb 12, 2024
ansgarm
reviewed
Feb 12, 2024
ansgarm
force-pushed
the
fix/issue-3489
branch
from
092c3f4
to
500a0c8
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #3489
Description
We were using
CDKTF_LOG_FILE_DIRECTORYwithin our logger, but we never made it into a supported CLI flag. CDKTF configures yargs in a way that all environment variables with theCDKTF_prefix are treated as CLI flags. For commands that hadstrictenabled, that means that setting any non-supported flag with theCDKTF_prefix would cause the command to fail. This PR now adds support for this flag and it should work across all commands.