fix(cli): fix version detection for Java being a bit too optimistic about the package name #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bout the package name Resolves #1994
DanielMSchmidt
approved these changes
Aug 3, 2022
|
CI currently fails due to yargs/yargs-parser#452 |
Related to yargs/yargs-parser#452 which caused synth to fail. After this change TypeScript will only check types that are actually used in user code but not whether all types in dependencies are correct. We opted for this instead of pinning a version of yargs-parser without this bug because disabling this kind of checking will also help with future bugs that might occur and won't require an update of the TypeScript template. Thus this change also helps with #1991
ansgarm
force-pushed
the
fix-java-cdktf-version-detection
branch
from
84a8eb4
to
2213ca2
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1994