feat(cli): match multiple stacks with patterns #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
advanced-stack-selection
branch
from
f220db5
to
46a36c6
Compare
ansgarm
reviewed
Mar 22, 2022
There was a problem hiding this comment.
Looking forward to this 💪
Have you checked whether it is possible to use * or ? in a stack name (i.e. in the id of a construct)? If yes, we should restrict that I'd say.
Mentioning this new feature in our docs (+ mentioning minimatch) would also be useful. Maybe it also makes sense to add this to the CLI args description?
DanielMSchmidt
force-pushed
the
advanced-stack-selection
branch
from
6a0724d
to
04fb60b
Compare
|
@ansgarm I added the check in TerraformStack 👍 |
ansgarm
reviewed
Mar 22, 2022
ansgarm
reviewed
Mar 22, 2022
DanielMSchmidt
force-pushed
the
advanced-stack-selection
branch
from
6a38ae2
to
e731fd0
Compare
Co-authored-by: Ansgar Mertens <[email protected]>
ansgarm
approved these changes
Mar 23, 2022
This was referenced Mar 24, 2022
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to select stacks using wildcards