Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default license secret name to null #229

Merged
merged 6 commits into from
Oct 9, 2023
Merged

default license secret name to null #229

merged 6 commits into from
Oct 9, 2023

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Oct 4, 2023

Background

When running tests for #227 I noticed that the tests broke after 1) changing from using legacy to replicated in non-FDO deployments, and 2) that when we changed the default to be FDO tests, we needed account for the Replicated license secret not being there if it's an FDO deployment.

How Has This Been Tested

Below.

The following pass:

  • private-active-active
  • private-tcp-active-active
  • public-active-active
  • standalone-external
  • standalone-mounted-disk
  • private-active-active-replicated
  • private-tcp-active-active-replicated
  • public-active-active-replicated
  • standalone-external-replicated
  • standalone-mounted-disk-replicated

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Oct 4, 2023

/test public-active-active

✅ Terraform Azure Public Active/Active (FDO) (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth anniehedgpeth changed the title default license to null default license secret name to null Oct 4, 2023
@anniehedgpeth anniehedgpeth marked this pull request as ready for review October 4, 2023 20:29
@anniehedgpeth anniehedgpeth requested a review from a team as a code owner October 4, 2023 20:29
@anniehedgpeth
Copy link
Contributor Author

@theoskolnik This is in a good enough place to merge so that we can properly test your pr.

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Oct 9, 2023

/test all destroy=false

✅ Terraform Azure Standalone Mounted Disk (FDO) (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

✅ Terraform Azure Standalone Mounted Disk (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

✅ Terraform Azure Public Active/Active (FDO) (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

✅ Terraform Azure Private Active/Active (FDO) (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

✅ Terraform Azure Standalone External (FDO) (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

✅ Terraform Azure Standalone External (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

✅ Terraform Azure Private TCP Active/Active (FDO) (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

✅ Terraform Azure Private TCP Active/Active (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

❌ Terraform Azure Public Active/Active (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ❌ Run k6 Smoke Test

✅ Terraform Azure Private Active/Active (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Oct 9, 2023

/test public-active-active-replicated destroy=false

✅ Terraform Azure Public Active/Active (FDO) (FDO) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

✅ Terraform Azure Public Active/Active (Replicated) - Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth anniehedgpeth merged commit acf5d76 into main Oct 9, 2023
2 checks passed
@anniehedgpeth anniehedgpeth deleted the ah/null-license branch October 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants