-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default license secret name to null #229
Conversation
/test public-active-active ✅ Terraform Azure Public Active/Active (FDO) (FDO) - Test Report
|
@theoskolnik This is in a good enough place to merge so that we can properly test your pr. |
/test all destroy=false ✅ Terraform Azure Standalone Mounted Disk (FDO) (FDO) - Test Report
✅ Terraform Azure Standalone Mounted Disk (Replicated) - Test Report
✅ Terraform Azure Public Active/Active (FDO) (FDO) - Test Report
✅ Terraform Azure Private Active/Active (FDO) (FDO) - Test Report
✅ Terraform Azure Standalone External (FDO) (FDO) - Test Report
✅ Terraform Azure Standalone External (Replicated) - Test Report
✅ Terraform Azure Private TCP Active/Active (FDO) (FDO) - Test Report
✅ Terraform Azure Private TCP Active/Active (Replicated) - Test Report
❌ Terraform Azure Public Active/Active (Replicated) - Test Report
✅ Terraform Azure Private Active/Active (Replicated) - Test Report
|
/test public-active-active-replicated destroy=false ✅ Terraform Azure Public Active/Active (FDO) (FDO) - Test Report
✅ Terraform Azure Public Active/Active (Replicated) - Test Report
|
Background
When running tests for #227 I noticed that the tests broke after 1) changing from using
legacy
toreplicated
in non-FDO deployments, and 2) that when we changed the default to be FDO tests, we needed account for the Replicated license secret not being there if it's an FDO deployment.How Has This Been Tested
Below.
The following pass: