Remove boto and pip installation from default installation

[lawliet89]

Fixes #116

[brikis98]

Code changes look good. How did you test them?

[lawliet89]

modules/install-vault/install-vault was tested by building new AMIs and launching new instances successfully (with auto-unseal, if that matters).

I didn't test the example.

[brikis98]

We can't run automated tests automatically for external PRs for security reasons. Could you run those yourself? Or, if that's too much setup work, could you deploy the example with the new AMI and make sure the cluster comes up OK? Thank you!

[lawliet89]

The AWS IAM auth script (and thus the Boto requirement) is not even used at all for starting up a Vault cluster.

Are you OK if I test using the IAM Auth example instead?

I will see if I can make some more changes to only install Boto/Pip when needed for that example.

[brikis98]

Sure! As long as you're putting the new AMI through its paces and it works, I'd be confident in merging this. Thanks!

[lawliet89]

Did a couple of tests:

1. The IAM Auth example which spins up a Vault and Consul cluster and an additional EC2 instance that authenticates via IAM worked. (i.e. I was able to curl http://<auth instance ip>:8080 and get back a secret I defined.)
2. I set install_auth_signing_script in the Packer template to anything other than true and I can confirm that Boto and Pip were not installed and the sign-request.py script is deleted.

ubuntu@ip-10-158-3-212:~$ sudo apt list --installed | grep python-pip

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

ubuntu@ip-10-158-3-212:~$ ls /opt/vault/scripts/
ubuntu@ip-10-158-3-212:~$ ls /tmp/
systemd-private-b9c55fb6e3aa41549d63e9cbf8003c6b-systemd-timesyncd.service-hN1JET

[Etiene]

Thanks a lot for the PR and thanks for testing it!