Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EC2 example+templates' hashicups module path #90

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

jjti
Copy link
Contributor

@jjti jjti commented Mar 23, 2023

This fixes the EC2 templates hashicups module path. It's missing that extra / before modules.

This shouldn't require a version bump, because nothing in main or /modules changed, only the example + template

Testing

Ran make to generate the changes in the PR

Changed the UI template to use us-east-1 and ran TF apply:

locals {
  vpc_region       = "us-east-1"
  hvn_region       = "us-east-1"
  cluster_id       = "test-module-path-fix"
  hvn_id           = "test-module-path-fix-hvn"
  install_demo_app = true
  ssm              = true
}

@jjti jjti requested a review from crhino March 23, 2023 14:45
@jjti jjti changed the title Fix hashicups demo module path Fix EC2 example+templates' hashicups module path Mar 23, 2023
@jjti jjti merged commit 45882f2 into main Mar 24, 2023
@jjti jjti deleted the jjtimmons/fix-hashicups-module-path branch March 24, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants