update-hashicups-frontend #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! @lamadome just checking but this one doesn't apply to EC2 or ECS? And were you able to test this? |
|
@jjtimmons my bad. This only applies to K8S indeed. I tested it and @im2nguyen tested it as well. So I believe we are good. Thank you! |
|
Sounds good and approved. Noting it here for the future, but it'd be nice to port some of these improvements to the Azure module as well: https://github.com/hashicorp/terraform-azurerm-hcp-consul/blob/main/modules/k8s-demo-app/services/frontend.yaml#L52 |
jjti
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Hashicups to use the latest version. @im2nguyen suggested this change to make the turorial on canary deployment work.