Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSM var to optionally disable its use #59

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Conversation

jjti
Copy link
Contributor

@jjti jjti commented Sep 16, 2022

In our E2E tests, we can hit errors where the GH role does not have auth to make IAM roles. This adds an optional arg for whether to use SSM in the test.

Testing

E2E tested with settings below. HashiCups spun up, did not have SSM:

locals {
  vpc_region       = "us-east-1"
  hvn_region       = "us-east-1"
  cluster_id       = "hc-ec2-cluster"
  hvn_id           = "hc-ec2-cluster-hvn"
  install_demo_app = true
  ssh              = true
  ssm              = false
}

@jjti jjti requested a review from lamadome September 16, 2022 18:46
@jjti jjti force-pushed the jjtimmons/no-ssm-by-default branch from 312f252 to fd82694 Compare September 16, 2022 20:00
@jjti jjti changed the title Add SSM var to disable optionally disable its use Add SSM var to optionally disable its use Sep 16, 2022
@jjti jjti merged commit 555e1f7 into main Sep 16, 2022
@jjti jjti deleted the jjtimmons/no-ssm-by-default branch September 16, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants