Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS template updates #50

Merged
merged 46 commits into from
Sep 16, 2022
Merged

EKS template updates #50

merged 46 commits into from
Sep 16, 2022

Conversation

lamadome
Copy link
Contributor

@lamadome lamadome commented Aug 23, 2022

This is an update to the EKS template. It adds the ability to choose whether or not to deploy the HashiCups applications. It also includes better user feedback and self-documentation.

closes #55 (comment)

Jona Apelbaum and others added 30 commits July 6, 2022 00:22
Changes:
- Adding nginx to nomad file to be deployed  as a docker container
- Adding nginx and frontend to consul connect (mesh)
This reverts commit 53eb6dc.
Changed the output of the eks ui template
Added a v2 for the frontend on hashicups for later use within the learn guides
This reverts commit 5c88060.
@lamadome lamadome requested a review from jjti August 23, 2022 10:19
examples/hcp-ec2-demo/variables.tf Outdated Show resolved Hide resolved
examples/hcp-ec2-demo/variables.tf Outdated Show resolved Hide resolved
test/hcp/testdata/ec2-existing-vpc.golden Outdated Show resolved Hide resolved
Jona Apelbaum and others added 2 commits August 29, 2022 13:36
When deploying this, the security group was not set properly as I am creating a new security group but we still need to apply the security group created by the aws.hcp module
@jjti jjti changed the base branch from main to ec2-tenplate-updates September 1, 2022 14:45
@jjti jjti force-pushed the eks-template-updates branch 2 times, most recently from f41d2d8 to 9c05f06 Compare September 15, 2022 20:42
@jjti jjti changed the title Eks template updates EKS template updates Sep 15, 2022
@jjti
Copy link
Contributor

jjti commented Sep 15, 2022

I tested the EKS and ECS modules and was able to deploy and order with both

Screen Shot 2022-09-15 at 8 23 13 PM

I was also able to list pods:

hcp-ui-templates/eks on git:eks-template-updates ✖︎ [20:50:59]
→ export KUBECONFIG=$(terraform output -raw kubeconfig_filename)

# josh at josh-P6KR9LXL6P in ~/prod/test-hc/terraform-aws-hcp-consul/hcp-ui-templates/eks on git:eks-template-updates ✖︎ [20:51:16]
→ kubectl get pods
NAME                                          READY   STATUS    RESTARTS   AGE
consul-client-ggpmm                           1/1     Running   0          32m
consul-client-hbcks                           1/1     Running   0          32m

@jjti jjti force-pushed the eks-template-updates branch from 9c05f06 to f4e386b Compare September 15, 2022 20:56
@jjti
Copy link
Contributor

jjti commented Sep 15, 2022

Small changes I made:

  • returning an absolute path for the kube config

Screen Shot 2022-09-15 at 10 54 41 PM

Jona Apelbaum and others added 3 commits September 16, 2022 00:08
Dependencies are needed to avoid nomad jobs and servicedefaults to be applied before the server is actually running
Base automatically changed from ec2-tenplate-updates to main September 16, 2022 13:58
@jjti jjti force-pushed the eks-template-updates branch from d8e0368 to 83a58ed Compare September 16, 2022 14:08
@jjti jjti merged commit 4c713ce into main Sep 16, 2022
@jjti jjti deleted the eks-template-updates branch September 16, 2022 14:11
This was referenced Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hcp ecs client not working properly
2 participants