-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EKS template updates #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 53eb6dc.
Co-authored-by: Joshua Timmons <[email protected]>
Co-authored-by: Joshua Timmons <[email protected]>
…erraform-aws-hcp-consul into ec2-tenplate-updates
Co-authored-by: Joshua Timmons <[email protected]>
Changed the output of the eks ui template Added a v2 for the frontend on hashicups for later use within the learn guides
Co-authored-by: Joshua Timmons <[email protected]>
Co-authored-by: Joshua Timmons <[email protected]>
Co-authored-by: Joshua Timmons <[email protected]>
Co-authored-by: Joshua Timmons <[email protected]>
Co-authored-by: Joshua Timmons <[email protected]>
Co-authored-by: Joshua Timmons <[email protected]>
This reverts commit 5c88060.
jjti
reviewed
Aug 24, 2022
When deploying this, the security group was not set properly as I am creating a new security group but we still need to apply the security group created by the aws.hcp module
jjti
force-pushed
the
eks-template-updates
branch
2 times, most recently
from
September 15, 2022 20:42
f41d2d8
to
9c05f06
Compare
I tested the EKS and ECS modules and was able to deploy and order with both I was also able to list pods:
|
jjti
force-pushed
the
eks-template-updates
branch
from
September 15, 2022 20:56
9c05f06
to
f4e386b
Compare
Small changes I made:
|
Dependencies are needed to avoid nomad jobs and servicedefaults to be applied before the server is actually running
jjti
force-pushed
the
eks-template-updates
branch
from
September 16, 2022 14:08
d8e0368
to
83a58ed
Compare
jjti
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the EKS template. It adds the ability to choose whether or not to deploy the HashiCups applications. It also includes better user feedback and self-documentation.
closes #55 (comment)