Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 template updates #49

Merged
merged 34 commits into from
Sep 16, 2022
Merged

EC2 template updates #49

merged 34 commits into from
Sep 16, 2022

Conversation

lamadome
Copy link
Contributor

Changes to ec2 quickstart and module to enble features described in prd https://docs.google.com/document/d/1zleMpseFKMok_dZ7VVfjLqKwVUPiJT12p-gWvTlEbSA/edit

Jona Apelbaum added 8 commits July 6, 2022 00:22
Changes:
- Adding nginx to nomad file to be deployed  as a docker container
- Adding nginx and frontend to consul connect (mesh)
This reverts commit 53eb6dc.
hcp-ui-templates/ec2-existing-vpc/main.tf Show resolved Hide resolved
hcp-ui-templates/ec2-existing-vpc/main.tf Outdated Show resolved Hide resolved
modules/hcp-ec2-client/main.tf Outdated Show resolved Hide resolved
modules/hcp-ec2-client/main.tf Outdated Show resolved Hide resolved
modules/hcp-ec2-client/main.tf Outdated Show resolved Hide resolved
hcp-ui-templates/ec2-existing-vpc/main.tf Outdated Show resolved Hide resolved
hcp-ui-templates/ec2-existing-vpc/main.tf Outdated Show resolved Hide resolved
modules/hcp-ec2-client/main.tf Show resolved Hide resolved
modules/hcp-ec2-client/nomad-job.tf Outdated Show resolved Hide resolved
@jjti jjti changed the title Ec2 tenplate updates EC2 template updates Jul 28, 2022
Copy link
Contributor

@jjti jjti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just nits/clean-up sort of things, but otherwise LGTM

examples/hcp-ec2-demo/output.tf Show resolved Hide resolved
examples/hcp-ec2-demo/output.tf Outdated Show resolved Hide resolved
examples/hcp-ec2-demo/variables.tf Outdated Show resolved Hide resolved
examples/hcp-ec2-demo/variables.tf Outdated Show resolved Hide resolved
modules/hcp-ec2-client/variables.tf Show resolved Hide resolved
modules/hcp-ec2-client/nomad-job.tf Show resolved Hide resolved
modules/hcp-ec2-client/nomad-job.tf Show resolved Hide resolved
Jona Apelbaum and others added 6 commits August 29, 2022 13:36
When deploying this, the security group was not set properly as I am creating a new security group but we still need to apply the security group created by the aws.hcp module
Dependencies are needed to avoid nomad jobs and servicedefaults to be applied before the server is actually running
@jjti jjti merged commit b00823e into main Sep 16, 2022
@jjti jjti deleted the ec2-tenplate-updates branch September 16, 2022 13:58
This was referenced Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants