This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Ubuntu 18.04 Support #143
Merged
Ubuntu 18.04 Support #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brikis98
reviewed
Jun 26, 2019
| @@ -0,0 +1,63 @@ | |||
| # systemd-resolved Setup Script | |||
There was a problem hiding this comment.
Oh, cool addition!
What are the trade-offs between dnsmasq and systemd-resolved?
There was a problem hiding this comment.
It would be nice I think if you can go through hashicorp/consul#4155 to understand the thought process of adding this.
There was a problem hiding this comment.
Thanks for the pointer! Could you add a short summary to the README of this module, with a link to this thread for more details?
|
Oh, just realize there is a merge conflict. Could you rebase on master first? |
sharmaansh21
force-pushed
the
ubuntu-18.04
branch
from
9ff0d30
to
497461d
Compare
sharmaansh21
force-pushed
the
ubuntu-18.04
branch
from
206015d
to
423c2a2
Compare
|
@brikis98 Ready for another 👀 thank you. |
sharmaansh21
force-pushed
the
ubuntu-18.04
branch
from
423c2a2
to
84cc6ab
Compare
brikis98
approved these changes
Jul 11, 2019
sharmaansh21
force-pushed
the
ubuntu-18.04
branch
from
84cc6ab
to
fd74e4b
Compare
|
OK, thanks for the updates. I'll kick off tests one more time. |
|
All tests passed. Merging now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141