Pin EventBridge Terraform module version #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlanda
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
The version of the
terraform-aws-modules/eventbridge/awsmodule was not specified in thelambda-registratorTerraform module. Versions 2.0.0 and 2.1.0 of the eventbridge module were released today. These contain breaking changes requiring an incompatible and untested version of thehashicorp/awsTerraform provider (>= 4.64.0). Duringterraform initTerraform attempted to select the most recent version of the eventbridge module because the version was not specified, and this caused a version mismatch for theawsTerraform provider. This caused the acceptance tests to fail.This PR updates the
lambda-registratorTerraform module to pin the version of the AWS EventBridge module to v1.17.3 so the selection of the module is deterministic.It also updates the release in the CHANGELOG to match the beta4 version that will be released today.
How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist:
Tests addedNot applicable