Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support provider defined functions for Terraform HCL #99

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Feb 15, 2024

This adds support for provider defined functions (e.g. provider::framework::example("hi")) to the Terraform HCL syntax.

Resolves #98

src/terraform.yml Outdated Show resolved Hide resolved
@ansgarm ansgarm marked this pull request as ready for review February 16, 2024 08:06
@ansgarm ansgarm requested a review from a team as a code owner February 16, 2024 08:06
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left some comments

src/terraform.yml Outdated Show resolved Hide resolved
src/terraform.yml Outdated Show resolved Hide resolved
src/terraform.yml Outdated Show resolved Hide resolved
tests/snapshot/terraform/expressions_functions.tf.snap Outdated Show resolved Hide resolved
@ansgarm ansgarm force-pushed the support-tf-provider-defined-fns branch from b86f4f0 to 1b110a7 Compare February 19, 2024 16:16
@ansgarm ansgarm force-pushed the support-tf-provider-defined-fns branch from 2dc1969 to 3659378 Compare February 20, 2024 14:44
@ansgarm ansgarm requested a review from dbanck February 20, 2024 14:45
src/terraform.yml Outdated Show resolved Hide resolved
…vider defined functions to reflect Terraforms constraints on these
@ansgarm ansgarm requested a review from dbanck February 22, 2024 08:10
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a minor suggestions

src/terraform.yml Outdated Show resolved Hide resolved
@ansgarm ansgarm force-pushed the support-tf-provider-defined-fns branch from 014d3a8 to b8a932a Compare February 22, 2024 10:39
@ansgarm ansgarm merged commit 1141ac7 into main Feb 22, 2024
3 checks passed
@ansgarm ansgarm deleted the support-tf-provider-defined-fns branch February 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support provider-defined functions syntax
2 participants