-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support provider defined functions for Terraform HCL #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
commented
Feb 15, 2024
ansgarm
commented
Feb 15, 2024
dbanck
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left some comments
ansgarm
force-pushed
the
support-tf-provider-defined-fns
branch
from
February 19, 2024 16:16
b86f4f0
to
1b110a7
Compare
ansgarm
force-pushed
the
support-tf-provider-defined-fns
branch
from
February 20, 2024 14:44
2dc1969
to
3659378
Compare
dbanck
reviewed
Feb 21, 2024
…ers at the beginning of both
11 tasks
…vider defined functions to reflect Terraforms constraints on these
dbanck
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only a minor suggestions
Co-authored-by: Daniel Banck <[email protected]>
ansgarm
force-pushed
the
support-tf-provider-defined-fns
branch
from
February 22, 2024 10:39
014d3a8
to
b8a932a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for provider defined functions (e.g.
provider::framework::example("hi")
) to the Terraform HCL syntax.Resolves #98