Fix inline for-expression matching #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the inline-for regex, which used to break the highlighting of the rest of the file because it was never terminated.
In the old structure, the
end: \n
regex never matched the end of the line in the example, because theobject
repository would consume the{
at the end of the line (including the newline). By changing this to a singlematch
regex, we can now match the entire line and then delegate the second capture expression to thefor_expression_body
as before.This shouldn't affect any of our existing tests related to
for
-expressions.UX Before
UX After
Closes #113