Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligns Action with common format #13

Merged
merged 11 commits into from
May 6, 2024
Merged

Aligns Action with common format #13

merged 11 commits into from
May 6, 2024

Conversation

ksatirli
Copy link
Member

@ksatirli ksatirli commented May 4, 2024

Hello reviewers 👋🏼

This PR aligns the action with the common format used in setup-packer and setup-nomad.

JenGoldstrich
JenGoldstrich approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure why this diff is so much smaller but it seems fine, as with the nomad one I did not look much at the test file as I've never worked directly with nomad

@ksatirli ksatirli merged commit 14424f0 into main May 6, 2024
5 checks passed
@ksatirli ksatirli deleted the align-with-common-format branch May 6, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksatirli @JenGoldstrich