Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix underflow when clock is 0 #751

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix underflow when clock is 0 #751

wants to merge 2 commits into from

Conversation

mbver
Copy link

@mbver mbver commented Nov 11, 2024

when clock is 0, because it is uint64, 0 - 1 is underflow to math.MaxUint64. so snapshot clock will never be updated again because the first update give it the max value.

@mbver mbver requested a review from a team as a code owner November 11, 2024 02:50
@mbver mbver requested review from jmurret and removed request for a team November 11, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmurret jmurret Awaiting requested review from jmurret jmurret is a code owner automatically assigned from hashicorp/consul-core-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbver