Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the logger to log/slog #699

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thethorne48
Copy link

When embedding serf in an application, the logger can be difficult to configure and integrate into said application's logger. Removing the need to parse the log entries for the [<LEVEL>] prefix to determine what level they are will greatly simplify logging.

This will be a breaking change in the configuration, requiring the logger to the an slog instance instead of log.

Minor changes to be more in line with go standards.

Removes deprecated ioutil.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 20, 2023

CLA assistant check
All committers have signed the CLA.

@thethorne48 thethorne48 marked this pull request as ready for review August 20, 2023 23:26
@thethorne48 thethorne48 requested a review from a team as a code owner August 20, 2023 23:26
@thethorne48 thethorne48 requested review from rboyer and removed request for a team August 20, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants