Improved election debug logs #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging elections in production you want to know what happened in a particular term in order to identify what went wrong. Add term= to all of the relevent debug logs You also want to know which peers were contacted (their ID and their address) and what the result from them was so you know why an election was not won in a timely manner Finally the log that just says "votes" in the message field seems strange; improve the message.
ncabatoff
approved these changes
Aug 1, 2022
|
Thanks @benbuzbee, this looks helpful. |
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging elections in production you want to know what happened in
a particular term in order to identify what went wrong.
Add term= to all of the relevent debug logs
You also want to know which peers were contacted (their ID and their
address) and what the result from them was so you know why an election
was not won in a timely manner
Finally the log that just says "votes" in the message field seems
strange; improve the message.