Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export leader field #357

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Export leader field #357

merged 1 commit into from
Sep 26, 2019

Conversation

aalda
Copy link
Contributor

@aalda aalda commented Jul 24, 2019

Export the Leader field from LeaderObservation to make accessible the observation value.

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 24, 2019

CLA assistant check
All committers have signed the CLA.

@schristoff
Copy link
Contributor

Hey @aalda , thank you so much for this contribution! I wanted to know if you have any particular use case for this change?

@aalda
Copy link
Contributor Author

aalda commented Aug 30, 2019

Hi @s-christoff, I was using a custom observer to update some metadata about the cluster state, including the Leader address. But later, I found a more convenient way to do it. Anyway, I think that exporting that field makes the LeaderObservation usable and consistent with the PeerObservation.

@RobbieMcKinstry
Copy link
Contributor

LGTM

@briankassouf briankassouf merged commit f8b3a3d into hashicorp:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants