Fixes #282 #310
Merged
Fixes #282 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banks
requested changes
Mar 6, 2019
Co-Authored-By: s-christoff <[email protected]>
banks
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Great! Not everyone would agree but I tend to be more verbose and prefer more context where things are subtle. I'd be fine with fewer words here and a link to a more complete description but my goal is - don't make others (or us in a few months) have to go spelunking through multiple refactors again to uncover a good understanding of what this code does!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies function of
CommitTimeout