-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix key vault creation in Azure allowing the terraform run to upload certs #29
Conversation
THis allows the service principal to add the SSL certificates to the keyvault.
Add the Service Principal Application id to the access policy.
pull changes in from upstream
This reverts commit de64d2b.
PR for branch prior to closure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks to both of you!
LGTM 🌈
You're welcome @bnferguson. |
I am very glad that my small contribution helped in some way. |
Includes #22.
Ran into the same problem @ausfestivus did with the key vault setup in the bootstrap.
Luckily they wrote up their issues over in hashicorp/terraform-azurerm-terraform-enterprise#47 and in turn https://github.com/ausfestivus/tfe-demo/blob/master/azureKeyvaultTroubleshooting.md. The latter leading me to this branch, which solved my issues.
Of particular interest is the user creation being done in a way that it can be done in a single pass instead of requiring two
plan
andapply
passes (mine was still broken after that even but this these changes patched it up) described in this issue: hashicorp/terraform-provider-azurerm#1569 (comment)Hopefully @ausfestivus doesn't mind me opening a PR for their branch. :D (and thank you for such a great set of write ups!)