Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key vault creation in Azure allowing the terraform run to upload certs #29

Merged
merged 10 commits into from
Dec 11, 2019

Conversation

bnferguson
Copy link
Contributor

Includes #22.

Ran into the same problem @ausfestivus did with the key vault setup in the bootstrap.

Luckily they wrote up their issues over in hashicorp/terraform-azurerm-terraform-enterprise#47 and in turn https://github.com/ausfestivus/tfe-demo/blob/master/azureKeyvaultTroubleshooting.md. The latter leading me to this branch, which solved my issues.

Of particular interest is the user creation being done in a way that it can be done in a single pass instead of requiring two plan and apply passes (mine was still broken after that even but this these changes patched it up) described in this issue: hashicorp/terraform-provider-azurerm#1569 (comment)

Hopefully @ausfestivus doesn't mind me opening a PR for their branch. :D (and thank you for such a great set of write ups!)

Copy link

@erindatkinson erindatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks to both of you!

LGTM 🌈

@bnferguson
Copy link
Contributor Author

oh and thanks to @lhaig for getting this started in #22! 🎉

@bnferguson bnferguson merged commit 0583c2b into hashicorp:master Dec 11, 2019
@ausfestivus
Copy link
Contributor

You're welcome @bnferguson.
I think I spent about 4 or 5 hours walking the issues here and elsewhere to get to the underlying root causes and most feasible fix considering dependant and upstream issues. Hence the detailed write ups for the next poor sod that tried to wrap their brain around it.

@lhaig
Copy link
Contributor

lhaig commented Dec 14, 2019

I am very glad that my small contribution helped in some way.
I could not dedicate as much time as I wanted, and it looks like things have moved on quite a bit. Thank you everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants