Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config - upgrade fleet members version to 2024-04-01 #4509

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

stephybun
Copy link
Member

The GHA to regenerate the Terraform provider fails with multiple errors that look similar to:

cannot use id (variable of type "github.com/hashicorp/go-azure-sdk/resource-manager/containerservice/2024-04-01/fleets".FleetId) as "github.com/hashicorp/go-azure-sdk/resource-manager/containerservice/2023-10-15/fleets".FleetId value in argument to client.Get

The client for the Kubernetes Fleet resources are shared by resources that are both manually written and generated by Pandora:

  • azurerm_kubernetes_fleet_manager was previously generated by Pandora but was converted to a manually written resource due to limitations in generation
  • azurerm_kubernetes_fleet_member is still generated by Pandora

The client was updated from 2023-10-15 to 2024-04-01 for Fleet Managers but the Pandora generated Fleet Member resource is still defined to use 2023-10-15 resulting in a clash when regenerating the provider.

@stephybun stephybun requested a review from a team October 22, 2024 13:12
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❄️

@stephybun stephybun merged commit 0244bd0 into main Oct 25, 2024
3 checks passed
@stephybun stephybun deleted the config/fleet-member-upgrade-version branch October 25, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants