Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config - Adding support for AppPlatform 2024-05-01-preview to support Java_21 #4415

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Chambras
Copy link
Contributor

In order to support https://github.com/Azure/azure-rest-api-specs/blob/main/specification/appplatform/resource-manager/Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L14130

The current implementation is using github.com/tombuildsstuff/kermit/sdk/appplatform/2023-05-01-preview/appplatform
and would like to start the work to migrate out of kermit and use hashicorp/go-azure-sdk instaed.

Copy link

hashicorp-cla-app bot commented Sep 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎫

@katbyte
Copy link
Collaborator

katbyte commented Sep 19, 2024

👋 hey @Chambras - it seems the generated pr from this (#4420) caused the change detector action to break. we have a few PRs that need to go in today so i've reverted this and reopened it as #4424 for us to dig into next week

@Chambras
Copy link
Contributor Author

Sounds good @katbyte is there anything on my side I could do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants