Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/importer-rest-api-specs: refactoring dataapigeneratorjson to use the new Data API SDK Types #3836

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

tombuildsstuff
Copy link
Contributor

This PR refactors the importer-rest-api-specs's dataapigeneratorjson package to use the new Data API SDK types. This also includes introducing a transformation shim to map from the existing types into the Data API SDK types so that we can gradually migrate each component from using the existing types into the Data API SDK types, rather than doing this as a big bang.

Implements Phase 9 and 10 of #3754

@tombuildsstuff tombuildsstuff requested a review from a team February 21, 2024 16:11
@tombuildsstuff tombuildsstuff force-pushed the refactor/arm-importer-data-api-sdk-types branch 2 times, most recently from 0f4c3be to dee6c2c Compare February 21, 2024 16:51
@tombuildsstuff tombuildsstuff force-pushed the refactor/arm-importer-grouping-terraform branch from fdbbb11 to f140a47 Compare February 21, 2024 16:52
@tombuildsstuff tombuildsstuff force-pushed the refactor/arm-importer-data-api-sdk-types branch from dee6c2c to 9a894a3 Compare February 21, 2024 16:53
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some tests failing, but otherwise LGTM!

@tombuildsstuff tombuildsstuff force-pushed the refactor/arm-importer-grouping-terraform branch from f140a47 to 38f1ae7 Compare February 21, 2024 17:08
…n` package to use the new Data API SDK Types

Configuring this will come in a separate commit, but this commit groups this together
…for internal -> data api sdk types

This enables gradually migrating each component across to these types
@tombuildsstuff tombuildsstuff force-pushed the refactor/arm-importer-data-api-sdk-types branch from 2e968ed to 1bff7ae Compare February 21, 2024 17:09
Base automatically changed from refactor/arm-importer-grouping-terraform to main February 22, 2024 08:15
@tombuildsstuff tombuildsstuff merged commit 6c81c89 into main Feb 22, 2024
1 check passed
@tombuildsstuff tombuildsstuff deleted the refactor/arm-importer-data-api-sdk-types branch February 22, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor tool/importer-rest-api-specs Swagger Data Importer issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants