tools/generator-terraform: refactoring to use the new Data API SDK [Phase 5]
#3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
changed the base branch from
main
to
refactor/1-duplicating-models
tombuildsstuff
changed the title
tools/generator-terraform: refactoring to use the new Data API SDK
tombuildsstuff
added
tool/generator-terraform
tombuildsstuff
changed the title
tools/generator-terraform: refactoring to use the new Data API SDKtools/generator-terraform: refactoring to use the new Data API SDK [Phase 5]
This is no longer needed.
…ce this wasn't fully implemented
…80, matching Data API V2
…c out of the CLI command
…models This commit is as minimal a set of changes to account for the new Data API SDK models being used everywhere. There's additional refactoring needed here, but this'll happen in a follow up due to the size.
tombuildsstuff
force-pushed
the
refactor/5-terraform-generator
branch
from
58f733b to
84575e2
Compare
tombuildsstuff
changed the title
tools/generator-terraform: refactoring to use the new Data API SDK [Phase 5]tools/generator-terraform: refactoring to use the new Data API SDK [Phase 5 Part 1]
tombuildsstuff
changed the title
tools/generator-terraform: refactoring to use the new Data API SDK [Phase 5 Part 1]tools/generator-terraform: refactoring to use the new Data API SDK [Phase 5]
Co-authored-by: catriona-m <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
generator-terraformtool to use the new Data API SDK/Models.This includes only the minimal set of changes needed for this to compile and run with no changes - whilst there's some additional cleanup needed here I've laid the foundation for some of this (logging) before realising this needed to be split out.
This changeset also includes support for the Source Data Type - although at the current time we're still making Resource Manager expectations throughout the codebase, so it's mostly a placeholder for now.
Dependent on #3784