tools/data-api-differ: refactoring to use the new Data API SDK [Phase 4]
#3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
refactor/4-data-api-differ
branch
2 times, most recently
from
181db79 to
7845426
Compare
tombuildsstuff
changed the base branch from
main
to
refactor/1-duplicating-models
tombuildsstuff
force-pushed
the
refactor/4-data-api-differ
branch
from
7845426 to
f777630
Compare
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
catriona-m
approved these changes
Feb 16, 2024
tools/data-api-differ/internal/commands/detect_breaking_changes.go
Outdated
Show resolved
Hide resolved
tools/data-api-differ/internal/commands/output_resource_id_segments.go
Outdated
Show resolved
Hide resolved
tombuildsstuff
force-pushed
the
refactor/4-data-api-differ
branch
from
f777630 to
547c7c4
Compare
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #3784
This PR refactors the
./tools/data-api-differtool to use the updated models from./tools/data-api-sdk- which also adds support forSourceDataType(which enables diffing the Microsoft Graph API Definitions in the future).