tools/extract-tf-resource-ids: support for large changesets
#3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the `extract-tf-resource-id` tool such that it works with larger sets of changes which is necessary since both sets of API Definitions are currently being output.
tombuildsstuff
added
bug
tombuildsstuff
force-pushed
the
b/v1-differ
branch
2 times, most recently
from
0f36a0d to
656326d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
extract-tf-resource-idtool such that it works with larger sets of changes which is necessary since both sets of API Definitions are currently being output. This fixes an issue seen in #3339 where changesets containing over 3000 files changed wouldn't get a diff output.Since this'll be replaced in the not-too-distant future by #3315 - I've opted just to pull the raw diff (which is complete) rather than iterating over the pages (which doesn't appear to be supported by the GitHub SDK)
This PR also updated the GitHub Action, since it appears the file trigger/filter only takes note of the first 3000 files changed - and not the entire changeset - which should ensure this triggers for any API Definition regenerations until #3315 is implemented
Example comment using this PR: #3339 (comment)