Data API V2: set fields correctly back into model and various fixes/cleanup #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt and cleanup Default
tombuildsstuff
approved these changes
Nov 9, 2023
| @@ -17,7 +17,7 @@ func codeForOperation(operationName string, input importerModels.OperationDetail | |||
| sort.Ints(expectedStatusCodes) | |||
| output := dataApiModels.Operation{ | |||
| Name: operationName, | |||
| ContentType: input.ContentType, | |||
| ContentType: fmt.Sprintf("%s; charset=utf-8", input.ContentType), | |||
There was a problem hiding this comment.
FWIW this'll be a breaking change in the case of APIs which don't use JSON (Automation being an example that uses a non-JSON payload) - I don't think that's necessarily a bad thing - but we should validate that doesn't break things.
Which makes me wonder if we should be making this change in the importer instead, so that we can roll that out with the V1 API?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapped fields from the data definitions weren't being set correctly.
Also exposing the
ParentTypeNamein the v1 endpoint and removedDefaultin the v1 endpoint since this is not used.