Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: add ScVmm@2023-10-07 #3309

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Config: add ScVmm@2023-10-07 #3309

merged 2 commits into from
Nov 13, 2023

Conversation

neil-yechenwei
Copy link
Contributor

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @neil-yechenwei

Rather than using the name ScVmm we should make this SystemCenterVirtualMachineManager - but if we can fix that up this otherwise LGTM 👍

config/resource-manager.hcl Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff merged commit 2c37d9b into hashicorp:main Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants