Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/generator-go-sdk: updating the ID Parsers to use the new SegmentNotFound error type available in https://github.com/hashicorp/go-azure-helpers/pull/155 #2493

Merged

Conversation

tombuildsstuff
Copy link
Contributor

…ntNotFound` error type available in hashicorp/go-azure-helpers#155

This should allow providing more context on errors when parsing Resource ID types

Dependent on hashicorp/go-azure-helpers#155

…ntNotFound` error type available in hashicorp/go-azure-helpers#155

This should allow providing more context on errors when parsing Resource ID types
@tombuildsstuff tombuildsstuff force-pushed the f/resource-id-parsers-use-segment-not-found-error branch from f98fc02 to 4de63c2 Compare May 8, 2023 13:35
@tombuildsstuff tombuildsstuff added area/resource-ids Related to Resource IDs, Parsers and Formatters tool/generator-go-sdk Issues with the Go SDK Generator labels May 8, 2023
@tombuildsstuff tombuildsstuff requested a review from stephybun May 8, 2023 13:35
@tombuildsstuff tombuildsstuff changed the title tools/generator-go-sdk: updating the ID Parsers to use the new `Segme… tools/generator-go-sdk: updating the ID Parsers to use the new SegmentNotFound error type available in https://github.com/hashicorp/go-azure-helpers/pull/155 May 8, 2023
@tombuildsstuff
Copy link
Contributor Author

Dependent on hashicorp/go-azure-sdk#461

@tombuildsstuff tombuildsstuff marked this pull request as ready for review May 10, 2023 12:37
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 🥟

@tombuildsstuff tombuildsstuff merged commit 9a05e7f into main May 10, 2023
@tombuildsstuff tombuildsstuff deleted the f/resource-id-parsers-use-segment-not-found-error branch May 10, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resource-ids Related to Resource IDs, Parsers and Formatters tool/generator-go-sdk Issues with the Go SDK Generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants